Be more paranoid with sanity checking. (gdk_pixbuf_unref): Fix incorrect

1999-09-17  Federico Mena Quintero  <federico@redhat.com>

	* src/gdk-pixbuf.c (gdk_pixbuf_ref): Be more paranoid with sanity
	checking.
	(gdk_pixbuf_unref): Fix incorrect sanity check and comparison.

diff --git a/gdk-pixbuf/ChangeLog b/gdk-pixbuf/ChangeLog
index 90125f1a992ead907ccf60c0affbb94ba4d9f31c..9386fa3c570149465777f8e35d1d9c083c463d46 100644 (file)
--- a/gdk-pixbuf/ChangeLog
+++ b/gdk-pixbuf/ChangeLog
@@ -1,3 +1,9 @@
+1999-09-17  Federico Mena Quintero  <federico@redhat.com>
+
+       * src/gdk-pixbuf.c (gdk_pixbuf_ref): Be more paranoid with sanity
+       checking.
+       (gdk_pixbuf_unref): Fix incorrect sanity check and comparison.
+
 1999-08-09  Federico Mena Quintero  <federico@nuclecu.unam.mx>
 
        * src/io-png.c (image_save): Fixed compiler warnings.  Fixed write

diff --git a/gdk-pixbuf/gdk-pixbuf.c b/gdk-pixbuf/gdk-pixbuf.c
index 82acf793a5c5a4d7572ae5c6ac32c7d433c1246b..dc23940f2020e263670eab99d49eef03f30d519d 100644 (file)
--- a/gdk-pixbuf/gdk-pixbuf.c
+++ b/gdk-pixbuf/gdk-pixbuf.c
@@ -28,6 +28,7 @@ void
 gdk_pixbuf_ref (GdkPixBuf *pixbuf)
 {
      g_return_if_fail (pixbuf != NULL);
+     g_return_if_fail (pixbuf->ref_count > 0);
 
      pixbuf->ref_count++;
 }
@@ -36,10 +37,11 @@ void
 gdk_pixbuf_unref (GdkPixBuf *pixbuf)
 {
     g_return_if_fail (pixbuf != NULL);
-    g_return_if_fail (pixbuf->ref_count == 0);
+    g_return_if_fail (pixbuf->ref_count > 0);
 
     pixbuf->ref_count--;
-    if (pixbuf->ref_count)
+
+    if (pixbuf->ref_count == 0)
        gdk_pixbuf_destroy (pixbuf);
 }